Put OS-specific get-started instructions in tabs #2388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
force-pushed
the
get-started-os-options
branch
3 times, most recently
from
632add0 to
fe41815
Compare
bishabosha
force-pushed
the
get-started-os-options
branch
from
fe41815 to
71cf7e9
Compare
|
added some changes to reuse templates more |
julienrf
requested changes
May 2, 2022
There was a problem hiding this comment.
Thank you Jamie, this is a great improvement. I have tested it locally and the OS detection did work correctly. I think the proposed changes work well, but the implementation details may lead to complex stylesheets, and the choice of colors and styles is not consistent with the styles used everywhere else in the website.
bishabosha
force-pushed
the
get-started-os-options
branch
from
64f1dbb to
5bdcacd
Compare
|
new look: |
julienrf
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also integrated with all the translations of the page. As with the other PR, JS being disabled will show the "Other" tab by default, and expand the "test your setup" accordion.
sibling PR scala/scala-lang#1373