-
Notifications
You must be signed in to change notification settings - Fork 1k
Lower bound in tour includes dangers #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @som-snytt, however, I think it would be better to minimize the changes between the code snippet that does not contain a lower bound and the one that showcases a lower bound, to make it easier for the readers to understand the scope of type bounds. I suggest using |
The suggestion on the linked PR was that the naming of "List" was potentially confusing. If I'm allowed to muck with the entire example, is it OK to make it look like the familiar I was trying avoid changing too much, in case there are pedagogical reasons. |
I am fine with removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again, sorry for the additional work :) I think this is good to merge, I just left one minor suggestion.
@julienrf thanks for making it better |
Challenging to fit on a single tour slide, but tries to emphasize that there are two concepts in play: covariance and need for lower bound. The naming of the list example classes may or may not be a distraction.