Skip to content

Fix compiling warnings in a code example of tour/classes #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2022
Merged

Fix compiling warnings in a code example of tour/classes #2349

merged 2 commits into from
Mar 30, 2022

Conversation

TSLsun
Copy link
Contributor

@TSLsun TSLsun commented Mar 19, 2022

Hi,

While following the code examples in Classes (Tour of Scala) in IDE, I noticed some compile warnings as follows:

  • Type annotation required for public member (x and y)
  • Method with Unit result type is parameterless (printWarning)
  • Type annotation required for Unit definition (printWarning)

I tried to fix them in this PR :)

Thanks!

som-snytt
som-snytt approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xuwei-k xuwei-k merged commit 0afef9f into scala:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@som-snytt som-snytt som-snytt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TSLsun @som-snytt @xuwei-k