Skip to content

add documentation for scala3-migrate in the migration guide #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2022
Merged

add documentation for scala3-migrate in the migration guide #2289

merged 2 commits into from
Jan 18, 2022

Conversation

mlachkar
Copy link
Contributor

@mlachkar mlachkar commented Jan 6, 2022

No description provided.

@mlachkar mlachkar requested a review from julienrf January 6, 2022 21:19
@mlachkar mlachkar force-pushed the scala3-migrate branch 2 times, most recently from c55023e to 1a025a4 Compare January 6, 2022 21:42
@mlachkar
Copy link
Contributor Author

mlachkar commented Jan 7, 2022

please can you do a quick review @adpi2 ? thanks! I can not add you as a reviewer!

adpi2
adpi2 approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and suggestions, otherwise it looks good to me.

julienrf
julienrf requested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mlachkar, this is a great addition to the migration guide! I noticed several issues that should be addressed before we merge the PR.

@mlachkar mlachkar force-pushed the scala3-migrate branch 2 times, most recently from dd8acf4 to 9dfbb3e Compare January 11, 2022 15:25
@mlachkar mlachkar requested a review from julienrf January 11, 2022 15:26
@julienrf julienrf self-assigned this Jan 11, 2022
julienrf
julienrf reviewed Jan 18, 2022
View reviewed changes
@julienrf
Copy link
Contributor

julienrf commented Jan 18, 2022 •
edited
Loading

I see several discussions that have not been resolved, could you please mark them as resolved (if they are), or explain why you think they should not be addressed?

@julienrf julienrf assigned mlachkar and unassigned julienrf Jan 18, 2022
@mlachkar
Copy link
Contributor Author

Thank you for your review. All comments have been addressed, and are marked as Outdated, but now I also marked them as resolved.

@mlachkar mlachkar requested a review from julienrf January 18, 2022 08:40
@mlachkar
Copy link
Contributor Author

the build is failing because of:

Not related to my PR. maybe it's a temporary issue en typelevel, otherwise I will fix it in another PR

@mlachkar mlachkar merged commit 1b939f6 into scala:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

@adpi2 adpi2 adpi2 approved these changes

Assignees

@mlachkar mlachkar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlachkar @julienrf @adpi2