Skip to content

[zh-cn] Initialization and Introduction #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

byyue
Copy link
Contributor

@byyue byyue commented Dec 13, 2021

Translate Scala 3 Book into Chinese step by step.

  1. Complete the translation of the Introduction chapter.

@byyue
Copy link
Contributor Author

byyue commented Jan 12, 2022

@SethTisue @julienrf @eed3si9n @Philippus
Sorry to interrupt, but could you please take a look at this PR at your convenience?

@julienrf
Copy link
Contributor

Hello @byyue, thank you for the pull request (and for your patience!).

I didn’t have a look at how it works with the other translations, but we should not copy all the pages, if possible. Instead, we should only copy the translated pages. Did you try that approach?

@byyue
Copy link
Contributor Author

byyue commented Jan 12, 2022

Hello @byyue, thank you for the pull request (and for your patience!).

I didn’t have a look at how it works with the other translations, but we should not copy all the pages, if possible. Instead, we should only copy the translated pages. Did you try that approach?

Hi @julienrf, thank you so much for your prompt reply.

Yes I have already considered what you have mentioned. The key point is the parts I would like to translate are under a different file structure than past translations related to Scala 2. It looks like I'm the first person to try to do this.

Another point I considered was to provide a smooth reading experience for the reader: If a chapter has not yet been translated, they can read the original English version in the current directory structure instead of jumping to another link. That's why I copied all the pages.

I did spend some time reading the contribution doc and trying to find better solution but to no avail. If you have a preferable solution, please let me know!

@julienrf
Copy link
Contributor

Yes I have already considered what you have mentioned. The key point is the parts I would like to translate are under a different file structure than past translations related to Scala 2. It looks like I'm the first person to try to do this.

I did spend some time reading the contribution doc and trying to find better solution but to no avail. If you have a preferable solution, please let me know!

Sorry about that. Someone needs to check how to translate those pages then, but eventually there should be no need to copy the old files. (I can’t do that for now, unfortunately)

Another point I considered was to provide a smooth reading experience for the reader: If a chapter has not yet been translated, they can read the original English version in the current directory structure instead of jumping to another link. That's why I copied all the pages.

I understand but then the risk is that we end up with different English versions of the pages, which might bring a lot of confusion.

@byyue
Copy link
Contributor Author

byyue commented Feb 1, 2022

Yes I have already considered what you have mentioned. The key point is the parts I would like to translate are under a different file structure than past translations related to Scala 2. It looks like I'm the first person to try to do this.
I did spend some time reading the contribution doc and trying to find better solution but to no avail. If you have a preferable solution, please let me know!

Sorry about that. Someone needs to check how to translate those pages then, but eventually there should be no need to copy the old files. (I can’t do that for now, unfortunately)

Another point I considered was to provide a smooth reading experience for the reader: If a chapter has not yet been translated, they can read the original English version in the current directory structure instead of jumping to another link. That's why I copied all the pages.

I understand but then the risk is that we end up with different English versions of the pages, which might bring a lot of confusion.

As you suggested, I spent some time figuring out how to make this process more elegant. The current plan is to translate each chapter/section step by step and commit separately. Before the translation is complete, the work-in-progress would not be visible to the reader (but can be accessed directly via the specific link). Cloud you please re-review this? @julienrf

@byyue
Copy link
Contributor Author

byyue commented Feb 1, 2022

Could you please have a look at this as well? @eed3si9n

@eed3si9n
Copy link
Member

eed3si9n commented Feb 1, 2022

@byyue I'd love to but my Mandarin is not great.

@scala/docs-zh 祝大家新年快乐身体健康! could you plz review this?

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The front matter seems good, but could you please post a screenshot to show that it works as expected?

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrf julienrf merged commit 1c33d0b into scala:main Feb 2, 2022
@julienrf
Copy link
Contributor

julienrf commented Feb 2, 2022

Thank you!

@byyue
Copy link
Contributor Author

byyue commented Feb 2, 2022

Thank you! The front matter seems good, but could you please post a screenshot to show that it works as expected?

intro

@byyue byyue deleted the dev-2271 branch February 2, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants