Skip to content

Rework Scala 3 syntax rewriting doc in the migration guide #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2021
Merged

Rework Scala 3 syntax rewriting doc in the migration guide #2106

merged 2 commits into from
Aug 10, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Jun 30, 2021 •
edited
Loading

@adpi2
Copy link
Member Author

adpi2 commented Jul 12, 2021

@sjrd could you review this PR?

@SethTisue
Copy link
Member

@sjrd ping

adpi2 added 2 commits August 10, 2021 10:06
@adpi2
Rework syntax rewriting doc
5a0f5e1 
Give a bit more details about the new syntax.
Make it clear that one must rewrite to the new control structure
before rewriting to the indentation based syntax.
Show the example in that order.
Simplify the example (it is not a reference).
@adpi2
Update link to Scala 3 reference
167d0b3
@adpi2 adpi2 force-pushed the fix-syntax-rewriting branch from af62827 to 167d0b3 Compare August 10, 2021 08:08
@adpi2 adpi2 requested a review from sjrd August 10, 2021 08:12
@sjrd sjrd merged commit 0fc97e0 into scala:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syntax rewrites page contradicts indentation documenation
3 participants
@adpi2 @SethTisue @sjrd