Old style Scala 2 If-else expression

[Altair-Bueno]

if (<condition>) <doThis> else <doThat> syntax is from Scala 2. Use if <condition> then <doThis> else <doThat> instead or simplify it by removing the if-else expression. If-else is unnecessary so i removed it. I already tested this code using REPL. It does work as intended

$ scala3-repl
scala> def isNullOrEmpty(s: String): Boolean = s==null || s.trim.equals("")
def isNullOrEmpty(s: String): Boolean

scala> isNullOrEmpty (null)
val res0: Boolean = true

scala> isNullOrEmpty ("")                                                                            
val res3: Boolean = true

scala> isNullOrEmpty ("hello")                                                                     
val res1: Boolean = false

[SethTisue]

nice catch.

also, while we're changing this example, s.trim.equals("") isn't idiomatic Scala. s.trim == "" would be a little better and s.trim.isEmpty would be better still

fyi @alvinj

[Altair-Bueno]

@SethTisue i changed s.trim.equals(") to s.trim.isEmpty as you suggested. Should be good to go

[Altair-Bueno]

I found another isNullOrEmpty. This time it was using Scala's 3 syntax instead of Scala 2, but i changed it to match 'A taste of Scala' section

[Philippus]

Thanks!