Suggestions in the Scala book (3) #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
changed the title
alvinj
reviewed
Jun 12, 2021
|
@julienrf, when I review these, is it better to click the Comment button when making a comment, or to press the Review button? I used the Comment approach with the “functions” suggestion, and Review button with the “comma after ‘definition’” suggestion. Update: Whoops, it looks like the Review button started a review process on this file, so I’ll continue with it. |
alvinj
suggested changes
Jun 12, 2021
| @@ -233,7 +234,7 @@ Here’s a method named `isTruthy` that implements the Perl definitions of `true | |||
|
|
|||
| ```scala | |||
| def isTruthy(a: Any) = | |||
| if a == 0 || a == "" then | |||
| if a == 0 || a == "" || a == false then | |||
There was a problem hiding this comment.
Wow, thanks, this is a great catch! No telling how many times I’ve written that wrong.
I’ve reviewed the chapters Methods, Functions, and Packaging and Imports.
julienrf
force-pushed
the
scala3-book-suggestions-part3
branch
from
dfb6540 to
273a57f
Compare
I like the review button because it sends me just one email notification 😊 Thank you for the review, Alvin! |
|
You’re welcome, I’m glad to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve reviewed the chapters Methods, Functions, and Packaging and Imports.
I kindly request a review by @alvinj 😊