Skip to content

Update naming-conventions.md: remove duplications #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

hiramekun
Copy link
Contributor

I found duplications of naming conventions, so I just removed them.
It seems naming conventions of "Methods" are already written in the above section.

@SethTisue SethTisue changed the title Remove duplicaitons in naming-conventions. Remove duplications in naming-conventions. May 18, 2021
@hiramekun hiramekun changed the title Remove duplications in naming-conventions. Update naming-comventions.md: remove duplications May 19, 2021
@hiramekun hiramekun changed the title Update naming-comventions.md: remove duplications Update naming-conventions.md: remove duplications May 19, 2021
@SethTisue
Copy link
Member

could someone watching the repo review this...?

Copy link
Member

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@hiramekun hiramekun requested a review from joroKr21 July 11, 2021 13:05
@hiramekun
Copy link
Contributor Author

The failure of this workflow is below.

This is referenced in this PR and this might fix it.

#2116

@Philippus Philippus merged commit 01c92bd into scala:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants