update parameterlists #1652
Merged
update parameterlists #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnhoekstra
force-pushed
the
curryingUpdate
branch
from
c093fa7 to
feff51f
Compare
SethTisue
reviewed
Mar 29, 2020
|
based on the feedback, and re-reading what I wrote, I expanded on what is inferred and why a bit more. |
SethTisue
reviewed
Mar 30, 2020
_tour/multiple-parameter-lists.md
Outdated
| ``` | ||
|
|
||
| this would not be possible with only a single parameter list, as the Scala compiler would not be able to infer the parameter types of the function. | ||
| This definition doesn't need any type hints and can infer all of its parameters. |
There was a problem hiding this comment.
s/parameters/type parameters/
martijnhoekstra
force-pushed
the
curryingUpdate
branch
4 times, most recently
from
140d48a to
05a797e
Compare
martijnhoekstra
force-pushed
the
curryingUpdate
branch
from
05a797e to
05ebd99
Compare
SethTisue
approved these changes
Mar 30, 2020
|
thanks Martijn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tour section for multiple parameterlists.
I wasn't able to understand the text in a way that actually reflected how scala worked, so I re-wrote it entirely. Should close #1647 that was also confused about what the intent was.
@zuliandri2 is this more helpful than the original?