Update for Scala 2.13 #1446
Merged
Update for Scala 2.13 #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philippus
reviewed
Jul 19, 2019
| Macro annotations are only available with the macro paradise plugin (in Scala 2.10.x, 2.11.x and 2.12.x alike). | ||
| Their inclusion in official Scala might happen in Scala 2.13, but there is no certainty about it yet. | ||
| Follow the instructions at the ["Macro Paradise"](paradise.html) page to download and use our compiler plugin. | ||
| Macro annotations are available in Scala 2.13 with the `-Ymacro-annotations` flag, but only with the macro paradise |
There was a problem hiding this comment.
The second part is a hard to parse for me. Suggestion: , and with the macro paradise plugin from Scala 2.10.x to Scala 2.12.x
|
@dcsobral interested in updating this based on the review feedback? |
|
Uh, you guys can alter the PR directly. I think. :) Since I edited the file
directly on github to create the PR, I don't have these changes locally.
--
Daniel C. Sobral
…On Tue, Jul 30, 2019 at 2:24 PM Seth Tisue ***@***.***> wrote:
@dcsobral <https://github.com/dcsobral> interested in updating this based
on the review feedback?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1446?email_source=notifications&email_token=AABCOF264A74IQC7FQTUWIDQCCPRVA5CNFSM4IFKKOG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3FGSFA#issuecomment-516581652>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCOF4XLEY6E6GE5LOCIN3QCCPRVANCNFSM4IFKKOGQ>
.
|
|
I'll merge this one and put my suggestion in another PR. Thank you @dcsobral ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.