-
Notifications
You must be signed in to change notification settings - Fork 1k
Localized Overview index page #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This seems great, we'd be happy to have it. However I'm having a bit of difficulty building it locally, by just running:
Not sure what the issue is right this moment, looking into it... |
Problem solved- nevermind the concern. This looks great! Thanks a lot for putting this together. Let me first poke around a bit and make a couple of tweaks, and then I'll pull it right in. Thanks again. |
poke. |
Thanks for the nudge. :) |
Localized Overview index page
Thanks for getting this in. I see that Collections library translation got deployed, but not the Overviews landing page. |
Thanks for your message. I'm most certainly aware of this. I'm currently in the process of debugging. Your patch has a few issues (both layout and functionality-- e.g. you can no longer toggle to any other language, Japanese, Spanish, etc, from And, as usual, github is having issues generating the site, which is why it's currently not live. It will be live when I commit some fixes. |
The
But until this pull request overview posts like Futures writeup didn't actually contain |
ok. I think I figured it out. It's a combo bug.
Adding
Should I send this as a pull req? |
Hi
I've been translating/porting a bunch of overview docs into Japanese lately. I figured it'd be nice to have a nice landing page for them so decided to localize the index page. See:
changes
overview: xyz
entry was added YAML frontmatter to link the English originals to the translations. For example:On the translated side, we just need to add the same entry. I also changed
guides-index
so the flags show up on the unused right-hand side span6. This is controlled bylanguages: ja
on Englishindex.md
.adding more languages
I've refactored the index page generation logic into
localized-overview-index.txt
so with minimal change Spanish index page should also be generated (@migue):index.md
following the Japanese sample.es
tolanguages: ja
in English index.md.