Fix a word from 'variable' to 'value' #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
propensive
reviewed
Jan 27, 2019
_tour/unified-types.md
Outdated
| @@ -40,7 +40,7 @@ val list: List[Any] = List( | |||
| list.foreach(element => println(element)) | |||
| ``` | |||
|
|
|||
| It defines a variable `list` of type `List[Any]`. The list is initialized with elements of various types, but they all are instance of `scala.Any`, so you can add them to the list. | |||
| It defines a value `list` of type `List[Any]`. The list is initialized with elements of various types, but they all are instance of `scala.Any`, so you can add them to the list. | |||
There was a problem hiding this comment.
There's a grammatical mistake on this line. How about, s/they all are instance of/each is an instance of/, or similar?
Philippus
approved these changes
Jan 28, 2019
|
"variable" is unfortunately ambiguous, but "value" is too; in e.g. regardless, this PR constitutes an improvement, so I'll merge it. but maybe we could do even better? not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At 6th paragraph in Tour of Scala - Unified Types, it seems that the wording 'variable' is actually meant to be 'value'.