Skip to content

Add Korean translation of Basics in tour #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

byeonggukgong
Copy link
Member

@byeonggukgong byeonggukgong commented Jul 22, 2018

  • Update page numbers

  • Translate basics.md in Korean

@byeonggukgong
Copy link
Member Author

byeonggukgong commented Jul 27, 2018

@heathermiller @SethTisue I would like to know the progress of this ticket review.

@SethTisue
Copy link
Member

hi! thanks for tackling this.

could another Korean speaker review this? perhaps you know somebody who could you ask to take a look...?

ultimately we'll end up merging it regardless, but we do normally prefer to have two sets of native-speaker eyes on translations if we can get them

@byeonggukgong
Copy link
Member Author

Thanks for answer!

I don't know official reviewer who can speak Korean. So that can a friend review the translations?

@SethTisue
Copy link
Member

sure, a friend is fine

@alicek106
Copy link

Actually, translating English to another language directly is not desirable. @byeonggukgong translated document very well only for each noun or verb, but not the whole sentences. I recommend @byeonggukgong to refine sentence considering readability for Korean readers.

For example, below sentence doesn't violate the original meaning of English sentence, but not naturally expressed in aspect of Korean context.

  • 실행 버튼을 눌러라. 오른쪽 창에 출력이 나타난다.

can be modified like this.

  • 실행 버튼을 누르면 오른쪽 창에서 출력 화면을 확인할 수 있다.

@byeonggukgong byeonggukgong changed the title Update basics.md Add Korean translations of tour Aug 9, 2018
@byeonggukgong byeonggukgong changed the title Add Korean translations of tour Add Korean translation of tour Aug 9, 2018
@byeonggukgong
Copy link
Member Author

@alicek106 Thanks for reviewed. It has helped me a lot!

I fixed it as you mentioned. Can I asked to verified the translation one more?

@jvican
Copy link
Member

jvican commented Aug 10, 2018

The CI is failing, it seems to be an error with the links. Could you have a look @byeonggukgong ?

@alicek106
Copy link

@byeonggukgong Translation is more naturally changed. I hope you to continue this works :D

@jvican
Copy link
Member

jvican commented Aug 15, 2018

Is this ready @byeonggukgong? Let's rebase this on top of master and we merge?

@byeonggukgong byeonggukgong force-pushed the master branch 2 times, most recently from 156f913 to f29aaba Compare August 16, 2018 00:35
* Update page numbers

* Translate basics.md in Korean
@byeonggukgong
Copy link
Member Author

byeonggukgong commented Aug 17, 2018

@jvican All the job well done. Let's merge it!

@SethTisue SethTisue merged commit 5e791c1 into scala:master Aug 17, 2018
@byeonggukgong byeonggukgong changed the title Add Korean translation of tour Add Korean translation of basics in tour Sep 4, 2018
@byeonggukgong byeonggukgong changed the title Add Korean translation of basics in tour Add Korean translation of Basics in tour Sep 4, 2018
bishabosha pushed a commit to bishabosha/docs.scala-lang that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants