-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Korean translation of Basics in tour #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@heathermiller @SethTisue I would like to know the progress of this ticket review. |
hi! thanks for tackling this. could another Korean speaker review this? perhaps you know somebody who could you ask to take a look...? ultimately we'll end up merging it regardless, but we do normally prefer to have two sets of native-speaker eyes on translations if we can get them |
Thanks for answer! I don't know official reviewer who can speak Korean. So that can a friend review the translations? |
sure, a friend is fine |
Actually, translating English to another language directly is not desirable. @byeonggukgong translated document very well only for each noun or verb, but not the whole sentences. I recommend @byeonggukgong to refine sentence considering readability for Korean readers. For example, below sentence doesn't violate the original meaning of English sentence, but not naturally expressed in aspect of Korean context.
can be modified like this.
|
@alicek106 Thanks for reviewed. It has helped me a lot! I fixed it as you mentioned. Can I asked to verified the translation one more? |
The CI is failing, it seems to be an error with the links. Could you have a look @byeonggukgong ? |
@byeonggukgong Translation is more naturally changed. I hope you to continue this works :D |
Is this ready @byeonggukgong? Let's rebase this on top of master and we merge? |
156f913
to
f29aaba
Compare
* Update page numbers * Translate basics.md in Korean
@jvican All the job well done. Let's merge it! |
fix dead links
Update page numbers
Translate basics.md in Korean