Use println() rather than print() #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
approved these changes
Apr 24, 2018
| @@ -42,7 +42,7 @@ def foo(n: Int, v: Int) = | |||
|
|
|||
| foo(10, 10) foreach { | |||
| case (i, j) => | |||
| print(s"($i, $j) ") // prints (1, 9) (2, 8) (3, 7) (4, 6) (5, 5) | |||
| println(s"($i, $j) ") // prints (1, 9) (2, 8) (3, 7) (4, 6) (5, 5) | |||
There was a problem hiding this comment.
the output would be
(1, 9)
(2, 8)
(3, 7)
(4, 6)
(5, 5)
There was a problem hiding this comment.
true, but not sure the difference is worth the vertical space
|
Hi @SethTisue @MasseGuillaume should I close this PR? Please advise. Thanks. |
|
thanks @XD-DENG! |
|
Thank you @SethTisue |
bishabosha
pushed a commit
to bishabosha/docs.scala-lang
that referenced
this pull request
Mar 21, 2022
Point the hacker guide to 2.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Not sure if there is any specific reason to use
print()here, but it doesn't print out anything in the console of Scalafiddle. This may be confusing/misleading to beginners like myself.So I would like to suggest to use
println()here in the sample code, which can print properly, rather than print().Please let me know your thought.