Skip to content

remove dead links #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2018
Merged

remove dead links #1035

merged 2 commits into from
Mar 14, 2018

Conversation

SethTisue
Copy link
Member

this came up in a CI run for an unrelated PR, see
https://platform-ci.scala-lang.org/scala/docs.scala-lang/374

@SethTisue SethTisue changed the title remove dead links to Java 5 remove dead links Mar 13, 2018
@SethTisue
Copy link
Member Author

so far so good on the Java 5 links, but there's still a link being reported as broken:

- ./_site/getting-started-intellij-track/getting-started-with-scala-in-intellij.html
  *  External link http://www.oracle.com/technetwork/java/javase/downloads/index.html failed: 401 No error

but when I curl that URL, I get 200, not 401. anyone know what could be causing this or what we should do about it...?

@heathermiller
Copy link
Member

Looks like ignoring the 401 code would fix it:
gjtorikian/html-proofer#336 (comment)

@heathermiller
Copy link
Member

This should work:
202dbde

(Don't have push rights to SethTisue/docs.scala-lang, otherwise I'd add it to this PR)

@SethTisue SethTisue merged commit c1ec083 into scala:master Mar 14, 2018
@SethTisue
Copy link
Member Author

thanks Heather

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants