-
Notifications
You must be signed in to change notification settings - Fork 1k
Navigation links are broken in "Tour of Scala" at http://docs.scala-lang.org #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue seems to be sitewide. The below URLs also do not work without the .html extension for example. http://docs.scala-lang.org/sips/all http://docs.scala-lang.org/overviews/core/architecture-of-scala-collections I guess it has to do with the permalink, I think adding the below line to
should fix it - https://jekyllrb.com/docs/permalinks/#permalink-style-examples. And it should work both ways i.e with and without the .html extension. But this is tricky to test as it works in local by default. |
It is important to use URLs in a consistent format. I'd suggest that use just A naive way may solve it: adding |
I agree on consistent URL format but I disagree on the |
I disagree with allowing both formats, i.e. with and without I apologize for the obscure explanation. |
Well, this is mainly for backporting. There are many links out there which could still point out to the
If we have a standard convention it should fix the Tour of Scala section as well along with others.
No issues. Glad that we are on the same page. |
http://docs.scala-lang.org/tour/basics giving 404. |
Now that #947 is merged, this issue is caught automatically during PR validation; see e.g. https://platform-ci.scala-lang.org/scala/docs.scala-lang/239. But a fix is still needed |
fix broken tour navigation links (issue #977)
I went ahead and did that in #983, since the broader issues here are unclear to me. |
Apologies, as @elpinal mentioned this works fine locally! |
Uh oh!
There was an error while loading. Please reload this page.
The bottom links, "next →" and "← previous", of each page of "Tour of Scala" are broken since those URLs are not given the suffix ".html".
For example, http://docs.scala-lang.org/tour/basics.html is accessible, but http://docs.scala-lang.org/tour/basics, which is "next →" in http://docs.scala-lang.org/tour/tour-of-scala.html indicates, responds with "404 Not Found error".
Note that running
bundle exec jekyll serve -I
in local works correctly.The text was updated successfully, but these errors were encountered: