Deduplicate historical Java version tag and upgrade client library #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new way of extracting the Java version doesn't include the internal build number, so remove that from historical data. First, upgrade the InfluxDB client library. This fixes two issues that I reported long ago with Nginx reverse proxy and basic authentication, so remove the workarounds. It also has a new feature to talk to the server in a binary protocal (Message Pack). Apart from being more efficient (which doesn't really matter much to us) it also doesn't lose track of int vs float data types when doing a bulk query (like we do in the migrator) which avoids needing to manually narrow "sampleCount" to a integral type.
retronym
force-pushed
the
topic/influx-client-bump-and-migrate-java-version
branch
from
777c6ad to
5581395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new way of extracting the Java version doesn't include the internal
build number, so remove that from historical data.
First, upgrade the InfluxDB client library.
This fixes two issues that I reported long ago with Nginx reverse proxy
and basic authentication, so remove the workarounds.
It also has a new feature to talk to the server in a binary protocal
(Message Pack). Apart from being more efficient (which doesn't really
matter much to us) it also doesn't lose track of int vs float
data types when doing a bulk query (like we do in the migrator)
which avoids needing to manually narrow "sampleCount" to a integral
type.