Skip to content

Add a Docker-based setup. #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Add a Docker-based setup. #601

merged 1 commit into from
Feb 6, 2023

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Feb 4, 2023

Based off #600.

I can't run Ruby 2.7.x on my machine anymore. Docker was the only solution I found. It may help others getting started to contribute to this website as well.

The setup is inspired by that of scala-lang.org, but modified to avoid UID hacker (instead has some volume hackery).

Based off scala-js#600.

I can't run Ruby 2.7.x on my machine anymore. Docker was the only
solution I found. It may help others getting started to contribute
to this website as well.

The setup is inspired by that of `scala-lang.org`, but modified to
avoid UID hackery (instead has some volume hackery).
@gzm0 gzm0 force-pushed the add-docker-setup branch from edb156f to d201cd5 Compare February 4, 2023 12:54
@gzm0 gzm0 requested a review from sjrd February 4, 2023 12:54
@gzm0 gzm0 mentioned this pull request Feb 4, 2023
@sjrd
Copy link
Member

sjrd commented Feb 4, 2023

Nice. This looks way cleaner for sure. Works well on my Windows machine. I'll try on Monday on the "problematic" Linux machine before merging.

Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on my Linux machine as well. And even though I have to run docker-compose with sudo, it doesn't create any file owned by root :)

@sjrd sjrd merged commit 6cd9855 into scala-js:main Feb 6, 2023
@gzm0
Copy link
Contributor Author

gzm0 commented Feb 6, 2023

And even though I have to run docker-compose with sudo, it doesn't create any file owned by root :)

Add your user to the docker group so you don't need to do that.

@gzm0 gzm0 deleted the add-docker-setup branch February 6, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants