Fix #6: Throw a structured exception when a command fails to start #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Jul 10, 2021
|
|
||
| @Test | ||
| def failingCommand: Unit = { | ||
| val run = ExternalJSRun.start(List("false"), ExternalJSRun.Config())(_.close()) |
There was a problem hiding this comment.
I would be surprised if this works on Windows.
| class ExternalJSRunFailureTest { | ||
|
|
||
| def assertFails(future: Future[Unit])( | ||
| pf: PartialFunction[Throwable, Unit]) = { |
There was a problem hiding this comment.
Either make this private or give it an explicit result type (or both).
|
|
||
| @Test | ||
| def abortedCommand: Unit = { | ||
| val run = ExternalJSRun.start(List("cat"), ExternalJSRun.Config()) { _ => |
| try { | ||
| builder.start() | ||
| } catch { | ||
| case t: Throwable => |
There was a problem hiding this comment.
We should probably restrict this to NonFatal exceptions, no?
sjrd
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.