Skip to content

Restore scalafix task to prePR #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Restore scalafix task to prePR #525

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
34843f8
Restore scalafix task to prePR
armanbilge Aug 30, 2021
0440105
Disable scalafix in prePR for Scala 3
armanbilge Aug 30, 2021
7be8476
Formatting
armanbilge Aug 30, 2021
e4b76ba
Scala 3 compile after scalafmt
armanbilge Aug 30, 2021
49869ae
Fix mistake
armanbilge Aug 30, 2021
d94c3fc
Fix build
armanbilge Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ val prePR_nonCross = taskKey[Unit]("Performs all necessary work required before
ThisBuild / prePR_nonCross := Def.sequential(
root / clean,
root / Compile / scalafmt,
root / Compile / compile,
Def.taskDyn {
if (scalaVersion.value.startsWith("2."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we indent this whole block within Def.taskDyn

(root / Compile / scalafix).toTask("")
else
Def.task(())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this to root / Compile / compile so that Scala 3 does a recompile after scalafmt? (I have had a few rare bad experiences and even though quite rare, I want to catch that if they pop up again)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes!

},
example / Compile / compile,
).value