Skip to content

Hardcode isSnapshot #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Hardcode isSnapshot #507

merged 1 commit into from
Aug 26, 2021

Conversation

armanbilge
Copy link
Member

No description provided.

@armanbilge armanbilge merged commit 3c3be26 into series/1.x Aug 26, 2021
@japgolly
Copy link
Contributor

Erm... @armanbilge ... what? Why? Isn't this going to cause the release action to try to do a full on 1.2.0 on every update to series/v1.x?

@japgolly
Copy link
Contributor

Did I forget to tell you that the 1.2.0 is already done and worked?

@armanbilge
Copy link
Member Author

Wait, what? So sorry ... I thought we still had to release?

@armanbilge
Copy link
Member Author

Erm... @armanbilge ... what? Why? Isn't this going to cause the release action to try to do a full on 1.2.0 on every update to series/v1.x?

Sorry, I thought the idea was to set this manually, do the release, then roll it back.

@japgolly
Copy link
Contributor

I just manually set the version in sbt (which sbt-dynver recognises as an override) and it seems to have worked. Don't close this yet though, we're actually lucky the release worked

Crap, this ↑ is what I wrote in a rush before I ran out the door but I can see how it would be unclear, hehe. My bad :D I set the version directly on the v1.2.0 tag.

@japgolly japgolly deleted the topic/fix-release branch August 26, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants