Add the CSSStyleRule.style property. #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Apr 1, 2020
| * | ||
| * MDN | ||
| */ | ||
| var style: CSSStyleDeclaration = js.native |
There was a problem hiding this comment.
According to the specification, style is readonly and SameObject, so it should be a val in Scala.js.
Once it's a val, there is no point in mentioning (Read only) in the Scaladoc. This is already better explained by the val keyword.
There was a problem hiding this comment.
That's my opinion as well, I'll change it.
…a/scala-js-dom into addStylePropertyToCSSStyleRule
sjrd
changed the title
sjrd
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.