Skip to content

Add the CSSStyleRule.style property. #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

shaneorama
Copy link
Contributor

No description provided.

*
* MDN
*/
var style: CSSStyleDeclaration = js.native
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the specification, style is readonly and SameObject, so it should be a val in Scala.js.

Once it's a val, there is no point in mentioning (Read only) in the Scaladoc. This is already better explained by the val keyword.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my opinion as well, I'll change it.

@sjrd sjrd changed the title Added style property to CSSStyleRule class Add the CSSStyleRule.style property. Apr 2, 2020
@sjrd sjrd merged commit 119b159 into scala-js:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants