Skip to content

Make the fields of RequestInit optional. #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2020
Merged

Make the fields of RequestInit optional. #381

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77ee1cb
Add default values for RequestInit fields
zakpatterson Sep 17, 2019
4fd656a
Merge master into fetch-api-default-field-values
zakpatterson Oct 29, 2019
674e012
Remove native from RequestInit
zakpatterson Oct 29, 2019
011e0c8
Simplify window field definition
zakpatterson Oct 29, 2019
55c1d66
Add default to RequestInit method, per review
zakpatterson Apr 29, 2020
4a136df
Merge branch 'master' into fetch-api-default-field-values
zakpatterson Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/main/scala/org/scalajs/dom/experimental/Fetch.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,29 +80,29 @@ class Request(input: RequestInfo, init: RequestInit = null) extends js.Object {
* the types.
*/
trait RequestInit extends js.Object {
var method: js.UndefOr[HttpMethod]
var method: js.UndefOr[HttpMethod] = js.undefined

var headers: js.UndefOr[HeadersInit]
var headers: js.UndefOr[HeadersInit] = js.undefined

var body: js.UndefOr[BodyInit]
var body: js.UndefOr[BodyInit] = js.undefined

var referrer: js.UndefOr[String]
var referrer: js.UndefOr[String] = js.undefined

var referrerPolicy: js.UndefOr[ReferrerPolicy]
var referrerPolicy: js.UndefOr[ReferrerPolicy] = js.undefined

var mode: js.UndefOr[RequestMode]
var mode: js.UndefOr[RequestMode] = js.undefined

var credentials: js.UndefOr[RequestCredentials]
var credentials: js.UndefOr[RequestCredentials] = js.undefined

var cache: js.UndefOr[RequestCache]
var cache: js.UndefOr[RequestCache] = js.undefined

var redirect: js.UndefOr[RequestRedirect]
var redirect: js.UndefOr[RequestRedirect] = js.undefined

var integrity: js.UndefOr[String]
var integrity: js.UndefOr[String] = js.undefined

var keepalive: js.UndefOr[Boolean]
var keepalive: js.UndefOr[Boolean] = js.undefined

var signal: js.UndefOr[AbortSignal]
var signal: js.UndefOr[AbortSignal] = js.undefined

/**
* The whatwg spec section on [[https://fetch.spec.whatwg.org/#requestinit RequestInit dictionary]]
Expand All @@ -111,7 +111,7 @@ trait RequestInit extends js.Object {
* it says even more clearly:
* "If init's window member is present and it is not null, throw a TypeError."
*/
var window: js.UndefOr[Null]
var window: js.UndefOr[Null] = js.undefined
}

/**
Expand Down