Skip to content

Fix #219: Fix Event constructors. #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 16, 2019
Merged

Fix #219: Fix Event constructors. #367

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5daceab
Add event constructors that accepts type name and init
May 15, 2019
8a85b9a
Deprecate object companion defined for limited number of ***EventInit
May 15, 2019
1c90901
MutationEvent has no constructor
May 15, 2019
882c079
Prefer import instead of qualified name at use site
May 15, 2019
dde36b2
Format blank lines
May 15, 2019
4457811
No need to limit to js.Any since data can be anything
May 15, 2019
b7194a5
Use js.native for argument that is not taken into account at runtime.
May 15, 2019
879d4ae
MutationEvent has no constructor
May 15, 2019
7f98757
No need to limit to js.Any since data can be anything
May 15, 2019
9e80c81
Workaround for deprecation warning on var
May 16, 2019
96938be
Remove unused trait
May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/scala/org/scalajs/dom/raw/lib.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4829,8 +4829,7 @@ trait MutationEventInit extends EventInit {
"WHATWG DOM")
@js.native
@JSGlobal
class MutationEvent(typeArg: String, init: js.UndefOr[MutationEventInit])
extends Event(typeArg, init) {
class MutationEvent extends Event("", js.undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it has no constructor, its constructor should be marked private. Otherwise there is nothing preventing to do new MutationEvent from the Scala side (with a run-time error).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 879d4ae

Used private[this] instead of private(), thanks to deprecation warning declaring private constructors in native JS classes is deprecated, because they do not behave the same way as in Scala.js-defined JS classes. Use `private[this]` instead. This will become an error in 1.0.0.

def newValue: String = js.native

def attrChange: Int = js.native
Expand Down