Skip to content
This repository was archived by the owner on Aug 9, 2018. It is now read-only.

Override ngAnimate, which dies in server context with no $rootElement #12

Merged
merged 3 commits into from
Jul 23, 2014

Conversation

kshay
Copy link
Contributor

@kshay kshay commented Jul 22, 2014

No description provided.

@jameswomack
Copy link

Should a test be added? Something like:

            test.ok(
                angular.modulesRegistered.indexOf('ngAnimate') !== -1,
                'ngAnimate module registered'
            );

@apparentlymart
Copy link
Collaborator

This seems reasonable as a way to make this a little easier to use with existing apps that may already try to use ngAnimate.

👍 to this (you already have collaborator access on this repo, I think), though I agree that some minimal testing would be nice.

@kshay
Copy link
Contributor Author

kshay commented Jul 23, 2014

Sure, added a test, and one for the fake ngRoute while we're at it.

kshay added a commit that referenced this pull request Jul 23, 2014
Override ngAnimate, which dies in server context with no $rootElement
@kshay kshay merged commit f896b39 into saymedia:master Jul 23, 2014
@jameswomack
Copy link

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants