Skip to content

Commit f896b39

Browse files
committed
Merge pull request saymedia#12 from kshay/master
Override ngAnimate, which dies in server context with no $rootElement
2 parents aa2af92 + 1a666ed commit f896b39

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

lib/ngoverrides.js

+4
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ function registerModule(context) {
1313
// depend on it but it makes no sense to run server-defined routes *on* the server.
1414
context.module('sdr', []);
1515

16+
// an app that depends on ngAnimate will fail on the absence of $rootElement in unbootstrapped
17+
// server context, and animation is not relevant on the server, so we just override it.
18+
context.module('ngAnimate', []);
19+
1620
// we depend on ngRoute here to be sure that, even if the application has provided the "real"
1721
// ngRoute module, we'll always register after it and get to override $route.
1822
var module = context.module('angularjs-server', ['ng', 'ngRoute']);

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angularjs-server",
3-
"version": "0.0.20",
3+
"version": "0.0.21",
44
"description": "A specialized server for AngularJS applications",
55
"author": "Martin Atkins <[email protected]>",
66
"keywords": ["angularjs"],

tests/wrap_middleware.js

+11-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
var path = require('path');
44

55
exports.testWrapMiddleware = function (test) {
6-
test.expect(11);
6+
test.expect(13);
77
var angularServer = require('../lib/main.js');
88

99
var server = angularServer.Server(
@@ -43,6 +43,16 @@ exports.testWrapMiddleware = function (test) {
4343
'angularjs-server module registered'
4444
);
4545

46+
test.ok(
47+
angular.modulesRegistered.indexOf('ngRoute') !== -1,
48+
'fake ngRoute module registered'
49+
);
50+
51+
test.ok(
52+
angular.modulesRegistered.indexOf('ngAnimate') !== -1,
53+
'fake ngAnimate module registered'
54+
);
55+
4656
test.ok(
4757
angular.requestsRegistered.length === 1,
4858
'nodejs request was registered exactly once'

0 commit comments

Comments
 (0)