Skip to content

Support for Hardware Number Generator #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

d00616
Copy link
Contributor

@d00616 d00616 commented Nov 6, 2016

This is an enhancement of https://github.com/sirleech/TrueRandom to nRF5 platform.

Contents:

  • Support for nRF5 and avr platform
  • New README.md, replaces readme
  • Fixed Example AllFunctions
  • Build library in .travis.yaml for nRF51 and nRF52

…eRandom

Contents:
- Support for nRF5 and avr platform
- New README.md, replaces readme
- Fixed Example AllFunctions
@sandeepmistry
Copy link
Owner

Hi @d00616,

Thanks for submitting this. Is there any reason you didn't submit a pull request to the original TrueRandom repo?

I'm not too keen about bundling this library with the core. The official Arduino cores usually just have SPI, Wire, SoftwareSerial. Then the rest are installable via the library manager, I've taken a similar approach with my BLEPeripheral library.

@d00616
Copy link
Contributor Author

d00616 commented Nov 7, 2016

Hello @sandeepmistry,

i have opened a pull request to the original library. This library isn't listed in library manager. So nobody can find this.

I like the Teensy way. The installer asks what Libraries, optimized for Teensy, have to installed. Whats about an Arduino Menu to install optimzed Libraries?

@sandeepmistry
Copy link
Owner

Whats about an Arduino Menu to install optimzed Libraries?

Not something I plan to work on. However, I'm open to adding links to the read me for "recommended" libraries.

@sandeepmistry
Copy link
Owner

I'm going to close this for now, since there's an upstream PR: sirleech/TrueRandom#1

If the original author does not merge, you can always consider renaming the library and ask the Arduino team to add the renamed library to the library manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants