-
-
Notifications
You must be signed in to change notification settings - Fork 284
Bugfix169 analog write #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
micooke
commented
Sep 17, 2017
•
edited
Loading
edited
- Fix bug PWM signal from analogWrite does not stop when pin is set to different mode #169
- wiring_analog_* : fallback to digitalWrite if no available PWM channel (copied from AVR core)
- wiring_analog_nRF52.c : convert pwmChannelPins & pwmChannelSequence -> pwmContext to semi-standardise pwm pin allocation and pwm status between nRF51 and nRF52
- wiring_private.h : Move pwm structures defines out of wiring_analog_* into wiring_private and make the instantiation of these structure externs instead of statics
- wiring_digital.c : disable the appropriate pwm timer when a digitalWrite is sent to an allocated (from analogWrite) pwm pin, and free up the pwm channel for re-allocation
* Incorporate changes based off feedback from @sandeepmistry and @dmikhalsky
# Conflicts: # platform.txt
* wiring_analog_* : fallback to digitalWrite if no available PWM channel (copied from AVR core) * wiring_analog_nRF52.c : convert pwmChannelPins & pwmChannelSequence -> pwmContext to semi-standardise pwm pin allocation and pwm status between nRF51 and nRF52 * wiring_private.h : Move pwm structures defines out of wiring_analog_* into wiring_private and make the instantiation of these structure externs instead of statics * wiring_digital.c : disable the appropriate pwm timer when a digitalWrite is sent to an allocated (from analogWrite) pwm pin, and free up the pwm channel for re-allocation
This PR has a bunch of stuff related to adding the BMP... Can remove those commits from this PR so I can merge it? Not a GitHub expert... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove BMP related changes
Oh sorry about that. I mustn't have rebased it properly - ill try and fix it today. |
What a mess, this is because i (stupidly) made the BMP changes to my trunk |
No worries. If its easier you could always just do a new PR. |
What do you see on you end post a PR? Do you get all my intermittent garbage logs and changes or just a unified change? If you get all the garbage ill redo both (and try to make it neater next time). |
I can see that there's been 7 commits to this PR with all of the individual changes per commit. I was hoping there was a way to just approve the last commit...either I can't find that button or it doesn't exist. |
You can use git cherrypick to merge specific commits on to a new branch and
then change to edit the PR to point at the new branch I think (or just
create a new PR)
Jeremy
…On Sep 29, 2017 2:11 AM, "dlabun" ***@***.***> wrote:
I can see that there's been 7 commits to this PR with all of the
individual changes per commit. I was hoping there was a way to just approve
the last commit...either I can't find that button or it doesn't exist.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#193 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF1WgOPMsn0Y0ugw_DmW3I5mOtdLoffPks5snEPMgaJpZM4PaU1Y>
.
|