Add support for setting StorageClass for state pvc #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new field statePVSCName in SmbCommonConfig.spec that allows users to specify StorageClass for Samba StatefulSet's state PVC. If not set, state PVC uses default StorageClass as before. Signed-off-by: FTS152 <[email protected]>
muff1nman
reviewed
May 3, 2025
| // StateSCName specifies which StorageClass is to be used for this share. | ||
| // If left empty, the operator's default will be used. | ||
| // +optional | ||
| StatePVSCName string `json:"statePVSCName,omitempty"` |
There was a problem hiding this comment.
I'd say that storageClassName is a bit more common of a name for something like this. I've never seen it abbreviated as PVSC
There was a problem hiding this comment.
My thought was that storageClassName might cause confusion with storageClassName in smbShare, as the two are used to configure different PVCs' storageClass.
|
This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch. |
Signed-off-by: FTS152 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field statePVSCName in SmbCommonConfig.spec that allows users to specify StorageClass for Samba StatefulSet's state PVC in ctdb cluster mode. If not set, state PVC uses default StorageClass as before.
For example:
Refs #340