gitlint: allow commit messages to contain long footnotes #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuiuk
previously approved these changes
Jul 21, 2023
obnoxxx
requested changes
Jul 21, 2023
anoopcs9
reviewed
Jul 24, 2023
phlogistonjohn
force-pushed
the
jjm-commit-footnotes
branch
from
363f55a to
7aa25b9
Compare
Ignore lines that start like `[1]: ` or `[2]: ` such that we can have long text like URLs in the commits without triggering other gitlint body rules. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-commit-footnotes
branch
from
7aa25b9 to
2cde6d1
Compare
|
This PR also enables the extremely useful feature of being able to put ascsii art in the message without tickling gitlint. Just prefix each line with |
phlogistonjohn
added a commit
to phlogistonjohn/samba-operator
that referenced
this pull request
Jul 25, 2023
Ignore lines that start like `[1]: ` or `[2] ` such that we can have long text like URLs in the commits without triggering other gitlint body rules. Copied from the same changes already made in samba-container (PR samba-in-kubernetes/samba-container#150). Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
added a commit
to phlogistonjohn/sambacc
that referenced
this pull request
Jul 25, 2023
Ignore lines that start like `[1]: ` or `[2] ` such that we can have long text like URLs in the commits without triggering other gitlint body rules. Copied from the same changes already made in samba-container (PR samba-in-kubernetes/samba-container#150). Signed-off-by: John Mulligan <[email protected]>
mergify bot
pushed a commit
to samba-in-kubernetes/samba-operator
that referenced
this pull request
Jul 25, 2023
Ignore lines that start like `[1]: ` or `[2] ` such that we can have long text like URLs in the commits without triggering other gitlint body rules. Copied from the same changes already made in samba-container (PR samba-in-kubernetes/samba-container#150). Signed-off-by: John Mulligan <[email protected]>
mergify bot
pushed a commit
to samba-in-kubernetes/sambacc
that referenced
this pull request
Jul 25, 2023
Ignore lines that start like `[1]: ` or `[2] ` such that we can have long text like URLs in the commits without triggering other gitlint body rules. Copied from the same changes already made in samba-container (PR samba-in-kubernetes/samba-container#150). Signed-off-by: John Mulligan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure gitlint to ignore lines that start like
[1]:or[2]such that we can have long text like URLs in the commits without triggering other gitlint body rules.PR contains two test commits to demonstrate the change that must be removed prior to merging.