This repository was archived by the owner on Dec 1, 2019. It is now read-only.
Fixes issues under windows with typescript 1.6, and moduleResolution flags #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some places, the windows typescript paths weren't being normalized, resulting in `C:\site\file.ts` rather than `C:/site/file.ts`. As the file names were used as keys to find modules, this resulted in relative modules not being found on windows. This was fixed my wrapping the files array in State with methods that would normalize the incoming path values. `files` was made private to ensure it wasn't used accidently.
The value "node" or "classic" needed to be converted into the
appropriate enum value, or the error:
Module build failed: TypeError: Cannot read property 'resolvedModule' of undefined
would occur.
|
@davidmiani thanks for your work, it's great! Everything looks quite correct, so I merge it. Please sorry for the delay with the answer. |
s-panferov
added a commit
that referenced
this pull request
Oct 31, 2015
Fixes issues under windows with typescript 1.6, and moduleResolution flags
|
@davidmiani landed as v0.14.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of problems here, fixed over two commits. Firstly, if a moduleResolution option was given in the tsconfig.json file, awesome-typescript would fail to compile any files. This was a problem if you needed "classic" resolution.
The other problem occurred with relative paths. Under windows, some paths weren't being normalized by awesome-typescript-loader, resulting in
C:\site\file.tsinstead ofC:/site/file.ts. When compared, these were found to be not equal. This was fixed by normalizing all paths before they were saved in the State class.