This repository was archived by the owner on Dec 1, 2019. It is now read-only.
fix(checker): pass through execArgv to checker child process #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows passing command-line options other than --debug and --inspect through to the type checker child process, e.g. --max-old-space-size to increase the available memory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing command-line options other than
--debugand--inspectthrough to the type checker child process, e.g.--max-old-space-sizeto increase the available memory.We are currently experiencing out-of-memory errors with TypeScript 2.4 and some complex types that we depend on. While we are working on fixing the typings to reduce memory consumption, we wanted to use the
--max-old-space-sizeoption as a workaround to increase the available memory for the Node.js process. We noticed however that this option is not being passed through to the type checker child process which is created by awesome-typescript-loader, only--debugor--inspectare passed.This PR keeps the special treatment for
--debugand--inspect, but passes all other options through to the created child process.