Skip to content

Add some new char and string convenience impls/methods #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2023
Merged

Add some new char and string convenience impls/methods #1013

merged 2 commits into from
Dec 1, 2023

Conversation

nicholasbishop
Copy link
Member

@nicholasbishop nicholasbishop commented Nov 30, 2023 •
edited by phip1611
Loading

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
Implement PartialEq<char> for Char8 and Char16
05a8211
@nicholasbishop
Add CStr16::from_char16_with_nul[_unchecked]
b936515 
These new methods mirror `from_u16_with_nul` and `from_u16_with_nul_unchecked`,
but take a `&[Char16]` slice instead of `&[u16]`.
@phip1611 phip1611 added this pull request to the merge queue Dec 1, 2023
Merged via the queue into rust-osdev:main with commit a6182b2 Dec 1, 2023
@nicholasbishop nicholasbishop deleted the bishop-char-improve branch December 1, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611