fix memory issue in memory-map #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
changed the title
phip1611
changed the title
|
That was a fun one, @YtvwlD :D |
phip1611
force-pushed
the
mem-fix
branch
2 times, most recently
from
9e436af to
727a182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via git-bisecting, I could find that d198dce broke something with the (legacy) memory map tag. This MR fixes the problem and adds a unit test for it.
The problem was that the MemoryMapTag became a DST by changing the last field to
areas: [MemoryArea]. TheTagTrait for MemoryMapTag-implementation returned a wrong DST size. Because of that, Rust thought that the DST is much larger than it actually is -> access to invalid memory.Also see: #133