-
Notifications
You must be signed in to change notification settings - Fork 28
Histogram error handling #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LukeMathWalker
merged 32 commits into
rust-ndarray:master
from
LukeMathWalker:histogram-error-handling
Apr 2, 2019
Merged
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
bfb0db7
Use Option as return type where things might fail
LukeMathWalker 4057a72
Test suite aligned with docs
LukeMathWalker fa1eb34
Equispaced does not panic anymore
669a33f
Fixed some tests
0e5eb6b
Fixed FD tests
04cf0a7
Fixed wrong condition in IF
4f429bc
Fixed wrong test
4e74c48
Added new test for EquiSpaced and fixed old one
56b7e45
Fixed doc tests
12906fd
Fix docs.
LukeMathWalker 9d1862f
Fix docs.
LukeMathWalker 64789d6
Fix docs.
LukeMathWalker fe150d1
Fmt
LukeMathWalker facd4c4
Merge master
LukeMathWalker b28c35a
Create StrategyError
LukeMathWalker c06f382
Fmt
LukeMathWalker 4a24f5a
Return Result. Fix Equispaced, Sqrt and Rice
LukeMathWalker f708a17
Fix Rice
LukeMathWalker 58788db
Fixed Sturges
LukeMathWalker 3014f77
Fix strategies
LukeMathWalker 17e5efc
Fix match
LukeMathWalker 63abed5
Tests compile
LukeMathWalker 4a4b489
Fix assertion
LukeMathWalker f692887
Fmt
LukeMathWalker a8ad4b1
Add more error types
jturner314 29f56f3
Rename StrategyError to BinsBuildError
jturner314 bca2dc9
Make GridBuilder::from_array return Result
jturner314 f41b317
Make BinsBuildError enum non-exhaustive
jturner314 308e0e7
Merge pull request #4 from jturner314/histogram-error-handling
LukeMathWalker c280c6b
Use lazy OR operator.
LukeMathWalker 6481509
Merge remote-tracking branch 'origin/histogram-error-handling' into h…
LukeMathWalker 701842d
Use lazy OR operator.
LukeMathWalker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.