Skip to content
This repository was archived by the owner on Nov 18, 2022. It is now read-only.

Add default channel setting & constrain channel values #318

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Add default channel setting & constrain channel values #318

merged 2 commits into from
Jun 4, 2018

Conversation

LDSpits
Copy link
Contributor

@LDSpits LDSpits commented May 16, 2018

This pull requests adds autocompletion and a (normal) default for the rust-client.channel setting.

closes #315

Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

package.json Outdated
],
"default": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing the string to a set of options is a great thing to do, however, I think the default should still be null since in that case we'll use whichever channel the user would normally use and that is probably the expected behaviour (e.g., using nightly if the user would usually build with nightly).

Copy link
Contributor Author

@LDSpits LDSpits May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrc Ahh, I didn't know that setting the value to null would do that! However, I do not think that null communicates "RLS updates itself based on the settings of your current toolchain config", can we maybe improve that somehow?

I for instance thought that it would default to stable (and have thus overridden the channel for every project that I have)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add some documentation of that to the tool tip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and added some explanation to the description. If you want it somewhere else feel free to say so :)

@nrc nrc merged commit 1fdd5e6 into rust-lang:master Jun 4, 2018
@nrc
Copy link
Member

nrc commented Jun 4, 2018

Thanks for the changes!

@LDSpits LDSpits deleted the feature/rls-channel-settings branch June 4, 2018 08:49
@LDSpits
Copy link
Contributor Author

LDSpits commented Jun 4, 2018

No problem :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add predetermined options for rust-client.channel config
2 participants