prevent libgccjit.so download on unsupported os/arch #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the gcc repository fork has moved to by under the rust-lang org
|
Ok, applied your suggestion regarding the message text change, fixed the conditional to be |
Co-authored-by: Guillaume Gomez <[email protected]>
GuillaumeGomez
approved these changes
Jun 1, 2024
antoyo
pushed a commit
to zedar/rustc_codegen_gcc
that referenced
this pull request
Jun 13, 2024
prevent libgccjit.so download on unsupported os/arch (rust-lang#529) Co-authored-by: Guillaume Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #528, I find it easier to show what I meant rather than tell.
Fixing up the download URL while at it.
fixes #527