Skip to content

Do not allow downloading libgccjit.so on other systems than Linux x86-64 in the build system #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antoyo opened this issue May 29, 2024 · 2 comments · Fixed by #529
Closed

Do not allow downloading libgccjit.so on other systems than Linux x86-64 in the build system #527

antoyo opened this issue May 29, 2024 · 2 comments · Fixed by #529
Assignees
@g4titanx
Labels
good first issue Good for newcomers

Comments

@antoyo
Copy link
Contributor

antoyo commented May 29, 2024

No description provided.

@antoyo antoyo added the good first issue Good for newcomers label May 29, 2024
@g4titanx
Copy link
Contributor

hey@antonyo, i would love to work on this
just to be sure, the build system should be in build_system/src/build.rs right?

@antoyo
Copy link
Contributor Author

antoyo commented May 30, 2024 •
edited
Loading

Yes, that is correct.
I suggest you print something like "Compile libgccjit yourself and set option XXXX" in the case where it's an unsupported platform.

@Skgland Skgland mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g4titanx g4titanx

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent libgccjit.so download on unsupported os/arch
2 participants
@antoyo @g4titanx