Sync Rust 2024-03-10 #468
Merged
Sync Rust 2024-03-10 #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update_cg_gcc_2024-03-05
Add asm goto support to `asm!` Tracking issue: #119364 This PR implements asm-goto support, using the syntax described in "future possibilities" section of [RFC2873](https://rust-lang.github.io/rfcs/2873-inline-asm.html#asm-goto). Currently I have only implemented the `label` part, not the `fallthrough` part (i.e. fallthrough is implicit). This doesn't reduce the expressive though, since you can use label-break to get arbitrary control flow or simply set a value and rely on jump threading optimisation to get the desired control flow. I can add that later if deemed necessary. r? ``@Amanieu`` cc ``@ojeda``
GuillaumeGomez
force-pushed
the
sync
branch
2 times, most recently
from
0c400bf to
6a339bf
Compare
antoyo
reviewed
Mar 10, 2024
| .display() | ||
| .to_string(); | ||
| if let Some(backend) = &self.backend { | ||
| rustflags.push(format!("-Zcodegen-backend={}", backend)); |
There was a problem hiding this comment.
You don't need sysroot here?
There was a problem hiding this comment.
Apparently not. This option is only used in the Rust CI (--backend),
There was a problem hiding this comment.
Ah makes sense since you compile the sysroot the usual way I guess.
Could you please add a comment to mention this?
antoyo
reviewed
Mar 10, 2024
rust-toolchain
Outdated
| channel = "nightly-2024-03-05" | ||
| components = ["rust-src", "rustc-dev", "llvm-tools-preview"] | ||
| channel = "nightly-2024-03-10" | ||
| components = ["rust-src", "rustc-dev", "llvm-tools-preview", "rustfmt"] |
There was a problem hiding this comment.
Because we need it to run cargo fmt (which is enforced in the CI).
There was a problem hiding this comment.
Yeah, but the people who only want to compile the project might not want it.
So, I would remove this unless you see a reason to keep it.
There was a problem hiding this comment.
Hum ok, removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.