Switch to config.toml instead of gcc-path
#427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
config-file
branch
7 times, most recently
from
5a8e903 to
8cd21d9
Compare
bjorn3
reviewed
Feb 9, 2024
build_system/src/config.rs
Outdated
| pub const CONFIG_FILE: &'static str = "config.toml"; | ||
|
|
||
| pub fn new() -> Result<Self, String> { | ||
| let content = fs::read_to_string(Self::CONFIG_FILE).map_err(|_| { |
There was a problem hiding this comment.
This requires config.toml to be at the root of the cg_gcc source, right? When building as part of rustc that will not work. The source directory should be assumed to be immutable, thus preventing that file to be created by either the user or the rust build system. You could add a way to configure where it will look for config.toml.
There was a problem hiding this comment.
Ah right I forgot about that, not great... Adding a command-line argument would fix it I suppose, thanks!
GuillaumeGomez
force-pushed
the
config-file
branch
from
77b7e74 to
1f24586
Compare
GuillaumeGomez
force-pushed
the
config-file
branch
5 times, most recently
from
5cdef40 to
aac6765
Compare
GuillaumeGomez
force-pushed
the
config-file
branch
from
aac6765 to
de9d1b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to support the
downloadcommand.