Skip to content

Remove unused dependency on object #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Oct 17, 2021

No description provided.

@antoyo
Copy link
Contributor

antoyo commented Oct 30, 2021

Sorry for not looking at this earlier.
I wanted to check what was using this crate before.
I couldn't find it, so do you happen to know what was using this crate?

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 30, 2021

Did you maybe copy it from cg_clif? Cg_clif uses it for creating the metadata object and used to use it for reading metadata from dylibs (now moved into cg_ssa).

@antoyo
Copy link
Contributor

antoyo commented Oct 30, 2021

You mean the archive code that was removed in this PR?

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 31, 2021

No, the metadata loader and dylib metadata writing.

@antoyo antoyo merged commit 08183f9 into rust-lang:master Oct 31, 2021
@antoyo
Copy link
Contributor

antoyo commented Oct 31, 2021

Oh well. I guess it's not that important to find anyway.
Thanks!

@bjorn3 bjorn3 deleted the remove_unused_object_dep branch October 31, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants