Publish latest build as release #1365
Conversation
|
For anyone who saw the current release at https://github.com/bjorn3/rustc_codegen_cranelift/releases/tag/dev, this was a test release to test if everything works. By the way did you get a notification every time or only for the first time a release was created under the dev tag? |
|
I received a notification the first time, but not since. Has there been a second? |
|
I was on this unfortunately, so I missed it.
I'm glad to help from now. Tell me what do you want to know. |
|
Now I'm on this instead:
|
|
FWIW I've been on "all activity" throughout.
|
|
Maybe to get a notification every time I did have to delete and recreate the release in the release action? |
I do not understand. Can we try right now? I'm here for you. |
|
I can't test it right now as I'm on my phone. I can write the code to delete the release before creating it tomorrow and then trigger a CI run for it. |
|
Ok. I'm here for you. |
bjorn3
force-pushed
the
dev-release
branch
2 times, most recently
from
59d5e45 to
b2b749c
Compare
|
Received a release notification. |
Me too. |
|
Another one now.
|
|
Got a notification for both releases in the github ui too. And it looks like the first notification is entirely gone after the second release, so it won't clobber the notification list if I push multiple times in a row. |
To ensure people who watch the repo for release notifications actually get a notification.
|
@bjorn3 I just received these two releases notifications emails, is that correct?
|
|
Yes, I first merged a PR and a bit later pushed another commit directly to master. |
This is easier to find than artifacts from the CI page and allows downloads without logging in. It also ensures that if I push a broken commit to the master branch people can still find the latest version that passes all tests.
I am still working on making cg_clif distributed with rustup, but until that is done this should be useful for people.
Closes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1337
cc https://github.com/bjorn3/rustc_codegen_cranelift/issues/1349#issuecomment-1478007590