-
Notifications
You must be signed in to change notification settings - Fork 107
Add Windows CI #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Windows CI #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Sep 27, 2022
bjorn3
reviewed
Sep 27, 2022
bjorn3
reviewed
Sep 27, 2022
bjorn3
reviewed
Sep 27, 2022
Co-authored-by: bjorn3 <[email protected]>
bjorn3
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will merge once CI passes.
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
With the upgrade to Cranelift 0.88 we can now enable MSVC in the build script and add some CI. This also adds CI for MinGW on Windows, which I didn't expect to hit so many issues, but it turns out MinGW is even more broken than I thought.
A summary of issues / tests disabled:
bench.simple-raytracer
Its just a build system issue.
test.regex-shootout-regex-dna
The actual file is mostly the same, I think this is just different line endings
abi-cafe
patchBut it looks like its not broad enough since
x86_64-pc-windows-gnu
still fails, so we temporarily disable thoseI'm going to follow up with
abi-cafe
to disable those tests on MinGW as wellrand
patchx86_64-pc-windows-gnu
presumably due to some broken implementations on the MinGW side? I haven't investigated this too far.cc #977