Avoid masking shift amounts #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to Cranelift 0.87.0 in bjorn3@b14c733. Can you please rebase? |
Cranelift 0.87 now follows its own documentation regarding shift amounts, and implicitly masks them if the arch requires it. [0] [0]: bytecodealliance/wasmtime@0508932
afonso360
force-pushed
the
mask-shift-amt
branch
from
39fa38e to
99ad6b9
Compare
bjorn3
added a commit
that referenced
this pull request
Aug 23, 2022
This reverts commit 156bda8. This breaks the mir_overflow_off rustc test: https://github.com/bjorn3/rustc_codegen_cranelift/runs/7971362755?check_suite_focus=true#step:7:2904
|
Unfortunately this breaks the mir_overflow_off rustc test: https://github.com/bjorn3/rustc_codegen_cranelift/runs/7971362755?check_suite_focus=true#step:7:2904 Reverted in b1e9d2e to make CI pass again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cranelift 0.87 now follows its own documentation regarding
shift amounts, and implicitly masks them if the arch requires it.
We need to wait for the 0.87 release before merging this.