Use native scalar fma instruction
#1267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonso360
force-pushed
the
native-fma
branch
3 times, most recently
from
04883d8 to
eda2eb1
Compare
|
Updated to Cranelift 0.87.0 in bjorn3@b14c733. Can you please rebase? |
Cranelift 0.87 now supports lowering `fma` as a libcall on x86 [0]. With 0.88 enabling the native x86 instruction under the `has_fma` flag. aarch64 and s390x already support this as a native instruction, so it's nice that we emit it for those. We can't lower the SIMD version using the `fma` instruction since the lowering can fail if the x86 `has_fma` flag is not enabled. Cranelift doesn't yet know how to fallback for these cases [0]: bytecodealliance/wasmtime@709716b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cranelift 0.87 now supports lowering
fmaas a libcall on x86.With 0.88 enabling the native x86 instruction under the
has_fmaflag.aarch64 and s390x already support this as a native instruction, so it's nice that we emit it for those.
We can't lower the SIMD version using the
fmainstruction since the lowering can fail if the x86has_fmaflag is not enabled. Cranelift doesn't yet know how to fallback for these cases.We need to wait for the 0.87 release before merging this.