-
Notifications
You must be signed in to change notification settings - Fork 107
Windows fixes #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows fixes #1195
Conversation
Copying Then it fails with
Weird, the toolchain's not on the path? Adding
at the begging of Then it fails with
Then `[TEST] rust-random/rand` fails: Running unittests (target\debug\deps\rand_distr-97e69b0a61466c32.exe)
running 50 tests
test dirichlet::test::test_dirichlet_invalid_length - should panic ... ok
test binomial::test::test_binomial_invalid_lambda_neg - should panic ... ok
// ...
test pareto::tests::sample ... ok
test pareto::tests::value_stability ... FAILED
test pert::test::test_pert ... ok
// ...
test weighted_alias::test::test_weighted_index_u8 ... ok
test weighted_alias::test::test_weighted_index_i128 ... ok
test weighted_alias::test::test_weighted_index_u128 ... ok
failures:
---- pareto::tests::value_stability stdout ----
---- pareto::tests::value_stability stderr ----
thread 'main' panicked at 'assertion failed: `(left == right)`
left: `[9.019295276219138, 4.3097126018270595, 6.837815045397156, 105.8826669383772]`,
right: `[9.019295276219136, 4.3097126018270595, 6.837815045397157, 105.8826669383772]`', rand_distr\src\pareto.rs:119:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
pareto::tests::value_stability
test result: FAILED. 49 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.23s Huh. Well that's certainly odd. I have no idea why |
3b08a4d
to
0f29682
Compare
Windows uses PDB instead of DWARF and using DWARF debuginfo causes the linker to give an error
Closing as outdated. Some parts have been fixed through the rewrite of the test harness in rust (by @afonso360) the rest had already landed on master I believe. There are still a couple of remaining issues for full Windows support though. |
Fixes the issues found in https://github.com/bjorn3/rustc_codegen_cranelift/issues/1193. This still needs testing on CI.
cc @EndilWayfare