Remove support for the old x86 Cranelift backend #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Uriopass Could you try if the audio issue from https://github.com/bjorn3/rustc_codegen_cranelift/issues/1129 is fixed with this? |
|
I will leave this PR open for the next couple of days in case anyone has an objection to it. |
|
Sadly the audio issues are still present with this PR :/ I'll dive a bit more to find the root cause. EDIT: finally succeeded in making a minimal example: |
This was referenced Feb 21, 2021
Closed
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the new Cranelift atomic instructions to be used that lower directly to native atomic instructions, which makes it possible to remove the ugly hack based on a global lock for all "atomic" accesses.