-
Notifications
You must be signed in to change notification settings - Fork 107
Re-upload build artifacts #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Artifact upload is enabled for linux and macos. Windows support is currently subpar, but I can try enabling artifact uploads for windows. |
Thanks. On that note, would it be feasible to use Github releases for the artifacts in the future? Asking because the binaries from CI expire after a while and can then no longer be downloaded. See here for example, which is the last successful build from a month ago. (Artifacts don't get attached to failing builds.) |
I enabled artifact uploads. I had to disable compression as xzip isn't supported by windows tar and bzip2 hangs. I hope to finish rust-lang/rust#81746 soon. This will cause cg_clif to be distributed with rustup, so |
Thanks a lot!
Oh wow that would be amazing! |
At the moment the artifact upload is disabled in the workflow here:
https://github.com/bjorn3/rustc_codegen_cranelift/blob/5f5a2f262f1d73355c8d782ec65f3774db728a4d/.github/workflows/main.yml#L155-L162
This might be a leftover of the Windows build.
Any chance we can re-enable the upload and trigger a new build? This would greatly help newcomers get started with cranelift as they wouldn't have to compile it on their machines first.
The text was updated successfully, but these errors were encountered: