Skip to content

Add --exact-match CLI argument to allow exact matching of benchmarks #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 27, 2025

To avoid problems with prefixes/suffixes in programmatic usage of the collector.

The argument name is bikesheddable, of course. --match/--select/--benchmarks?

Should unblock rust-lang/rust#141490.

@nnethercote
Copy link
Contributor

--exact or --exact-match?

To avoid problems with prefixes/suffixes in programmatic usage of the collector.
@Kobzol Kobzol changed the title Add --match CLI argument to allow exact matching of benchmarks Add --exact-match CLI argument to allow exact matching of benchmarks May 27, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented May 27, 2025

I like --exact-match, as it tells in the name that the matching is exact :) Changed to that.

@Kobzol Kobzol merged commit 9863312 into rust-lang:master May 27, 2025
11 checks passed
@Kobzol Kobzol deleted the cli-match branch May 27, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants